Conversation
0xh3rman
commented
Feb 18, 2026
0xh3rman
commented
- Refactor Client::resolve to select the best provider by longest domain match (with wildcard support) via a new matched_provider helper and domain_match_len function; prefer more specific provider results and propagate their errors. Add a NameError type for clearer error construction and export the error module.
- Introduce a TestProvider testkit (testkit.rs) to simplify provider mocking and add unit tests covering domain preference and error propagation. Extend ENS client domains (eth, com, xyz, dev) and add an integration test for resolving an imported ENS name.
- Also export the testkit module from lib.rs.
Refactor Client::resolve to select the best provider by longest domain match (with wildcard support) via a new matched_provider helper and domain_match_len function; prefer more specific provider results and propagate their errors. Add a NameError type for clearer error construction and export the error module. Introduce a TestProvider testkit (testkit.rs) to simplify provider mocking and add unit tests covering domain preference and error propagation. Extend ENS client domains (eth, com, xyz, dev) and add an integration test for resolving an imported ENS name. Also export the testkit module from lib.rs.
|
Review changes with Changed Files
|
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the name resolution system by improving how name providers are selected and errors are handled. It introduces a more sophisticated matching algorithm for domains, expands the range of supported ENS domains, and provides a dedicated test utility for easier mocking. These changes collectively make the name resolution process more reliable, flexible, and testable, ultimately supporting a wider array of domain name services. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a more robust domain matching logic for name resolution, allowing for specific provider selection based on the longest domain match and supporting wildcards. It also adds a useful testkit for mocking providers and expands ENS support to more TLDs. The refactoring improves maintainability and correctness. Some minor efficiency improvements are suggested for the matching logic to avoid unnecessary allocations and improve code clarity.
1 participant
